Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures part 2 #436

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Signatures part 2 #436

merged 1 commit into from
Jun 23, 2022

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Jun 22, 2022

PART2

Override for BZ 2073197 to override permissions bugzilla.redhat.com/show_bug.cgi?id=2073197#c19

Related: openshift/machine-config-operator#1349

Apparently, by mistake, a change in RHCOS image does try to verify signatures for the images, which are not currently mirrored or even provided, and this causes an issue.

There's an upstream issue listed to get this solved, but as a workaround we're disabling verification in Edge clusters via an ignition file and might in addition require a change in the installer image being used until RHCOS has the changes reverted and the related tooling is updated to mirror signatures, etc.

@iranzo
Copy link
Contributor Author

iranzo commented Jun 22, 2022

Same failure in 'deploy-metallb' as 'main'

@iranzo
Copy link
Contributor Author

iranzo commented Jun 23, 2022

Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flaper87 flaper87 dismissed alknopfler’s stale review June 23, 2022 10:41

Comment addressed

@flaper87 flaper87 requested a review from alknopfler June 23, 2022 10:42
Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iranzo iranzo merged commit 8feb56c into rh-ecosystem-edge:main Jun 23, 2022
@iranzo iranzo deleted the signature2 branch June 23, 2022 13:10
@iranzo
Copy link
Contributor Author

iranzo commented Jun 23, 2022

🎉 This PR is included in version 1.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants