Apply suggestions from code review

rh-hideout · Feb 21, 2023 · c4fe45e · c4fe45e
1 parent 6766b6e
commit c4fe45e
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/test/ability_damp.c b/test/ability_damp.c
@@ -27,7 +27,7 @@ DOUBLE_BATTLE_TEST("Damp prevents explosion-like moves from enemies in a double
     PARAMETRIZE { move = MOVE_MIND_BLOWN; }
     PARAMETRIZE { move = MOVE_MISTY_EXPLOSION; }
     GIVEN {
-        PLAYER(SPECIES_PARAS) { Ability(ABILITY_DAMP); };
+        PLAYER(SPECIES_PARAS) { Ability(ABILITY_DAMP); }
         PLAYER(SPECIES_WOBBUFFET);
         OPPONENT(SPECIES_WOBBUFFET);
         OPPONENT(SPECIES_WOBBUFFET);

diff --git a/test/ability_volt_absorb.c b/test/ability_volt_absorb.c
@@ -68,9 +68,9 @@ DOUBLE_BATTLE_TEST("Volt Absorb does not stop Electric Typed Explosion from dama
     GIVEN {
         ASSUME(gBattleMoves[MOVE_EXPLOSION].effect == EFFECT_EXPLOSION);
         ASSUME(gBattleMoves[MOVE_EXPLOSION].type == TYPE_NORMAL);
-        PLAYER(SPECIES_JOLTEON) { Ability(ABILITY_VOLT_ABSORB); HP(1); MaxHP(TEST_MAX_HP); };
+        PLAYER(SPECIES_JOLTEON) { Ability(ABILITY_VOLT_ABSORB); HP(1); MaxHP(TEST_MAX_HP); }
         PLAYER(SPECIES_ABRA);
-        OPPONENT(SPECIES_GRAVELER_ALOLAN) { Ability(ABILITY_GALVANIZE); };
+        OPPONENT(SPECIES_GRAVELER_ALOLAN) { Ability(ABILITY_GALVANIZE); }
         OPPONENT(SPECIES_WYNAUT);
     } WHEN {
         TURN { MOVE(opponentLeft, MOVE_EXPLOSION); }

diff --git a/test/move_effect_explosion.c b/test/move_effect_explosion.c
@@ -24,7 +24,7 @@ SINGLE_BATTLE_TEST("Explosion causes the user & the target to faint")
 {
     GIVEN {
         PLAYER(SPECIES_WOBBUFFET);
-        OPPONENT(SPECIES_WOBBUFFET) { HP(1); } ;
+        OPPONENT(SPECIES_WOBBUFFET) { HP(1); }
         OPPONENT(SPECIES_WOBBUFFET);
     } WHEN {
         TURN { MOVE(player, MOVE_EXPLOSION); }
@@ -73,9 +73,9 @@ DOUBLE_BATTLE_TEST("Explosion causes everyone to faint in a double battle")
 {
     GIVEN {
         PLAYER(SPECIES_WOBBUFFET);
-        PLAYER(SPECIES_WYNAUT) { HP(1); } ;
-        OPPONENT(SPECIES_ABRA) { HP(1); } ;
-        OPPONENT(SPECIES_KADABRA) { HP(1); } ;
+        PLAYER(SPECIES_WYNAUT) { HP(1); }
+        OPPONENT(SPECIES_ABRA) { HP(1); }
+        OPPONENT(SPECIES_KADABRA) { HP(1); }
         OPPONENT(SPECIES_KADABRA);
     } WHEN {
         TURN { MOVE(playerLeft, MOVE_EXPLOSION); }

diff --git a/test/move_effect_mind_blown.c b/test/move_effect_mind_blown.c
@@ -11,7 +11,7 @@ ASSUMPTIONS
 SINGLE_BATTLE_TEST("Mind Blown makes the user lose 1/2 of its HP")
 {
     GIVEN {
-        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST) ; MaxHP(HP_TEST) ;} ;
+        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST); MaxHP(HP_TEST); }
         OPPONENT(SPECIES_WOBBUFFET);
     } WHEN {
         TURN { MOVE(player, MOVE_MIND_BLOWN); }
@@ -25,7 +25,7 @@ SINGLE_BATTLE_TEST("Mind Blown makes the user lose 1/2 of its HP")
 DOUBLE_BATTLE_TEST("Mind Blown makes the user lose 1/2 of its HP in a double battle")
 {
     GIVEN {
-        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST) ; MaxHP(HP_TEST) ;} ;
+        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST); MaxHP(HP_TEST); }
         PLAYER(SPECIES_WOBBUFFET);
         OPPONENT(SPECIES_WOBBUFFET);
         OPPONENT(SPECIES_WOBBUFFET);
@@ -41,10 +41,10 @@ DOUBLE_BATTLE_TEST("Mind Blown makes the user lose 1/2 of its HP in a double bat
 SINGLE_BATTLE_TEST("Mind Blown causes the user to faint when below 1/2 of its HP")
 {
     GIVEN {
-        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2) ; MaxHP(HP_TEST) ;} ;
+        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2); MaxHP(HP_TEST); }
         OPPONENT(SPECIES_WOBBUFFET);
     } WHEN {
-        TURN { MOVE(player, MOVE_MIND_BLOWN);}
+        TURN { MOVE(player, MOVE_MIND_BLOWN); }
     } SCENE {
         HP_BAR(player, hp: 0);
         ANIMATION(ANIM_TYPE_MOVE, MOVE_MIND_BLOWN, player);
@@ -55,7 +55,7 @@ SINGLE_BATTLE_TEST("Mind Blown causes the user to faint when below 1/2 of its HP
 DOUBLE_BATTLE_TEST("Mind Blown causes the user to faint when below 1/2 of its HP in a double battle")
 {
     GIVEN {
-        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2) ; MaxHP(HP_TEST) ;} ;
+        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2); MaxHP(HP_TEST); }
         PLAYER(SPECIES_WOBBUFFET);
         OPPONENT(SPECIES_WOBBUFFET);
         OPPONENT(SPECIES_WOBBUFFET);
@@ -71,8 +71,8 @@ DOUBLE_BATTLE_TEST("Mind Blown causes the user to faint when below 1/2 of its HP
 SINGLE_BATTLE_TEST("Mind Blown causes the user & the target to faint when below 1/2 of its HP")
 {
     GIVEN {
-        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2) ; MaxHP(HP_TEST) ;} ;
-        OPPONENT(SPECIES_WOBBUFFET) { HP(1); } ;
+        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2) ; MaxHP(HP_TEST); }
+        OPPONENT(SPECIES_WOBBUFFET) { HP(1); }
         OPPONENT(SPECIES_WOBBUFFET);
     } WHEN {
         TURN { MOVE(player, MOVE_MIND_BLOWN);}
@@ -88,13 +88,13 @@ SINGLE_BATTLE_TEST("Mind Blown causes the user & the target to faint when below
 DOUBLE_BATTLE_TEST("Mind Blown causes everyone to faint in a double battle")
 {
     GIVEN {
-        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2) ; MaxHP(HP_TEST) ;} ;
-        PLAYER(SPECIES_WYNAUT) { HP(1); } ;
-        OPPONENT(SPECIES_ABRA) { HP(1); } ;
-        OPPONENT(SPECIES_KADABRA) { HP(1); } ;
+        PLAYER(SPECIES_WOBBUFFET) { HP(HP_TEST / 2); MaxHP(HP_TEST); }
+        PLAYER(SPECIES_WYNAUT) { HP(1); }
+        OPPONENT(SPECIES_ABRA) { HP(1); }
+        OPPONENT(SPECIES_KADABRA) { HP(1); }
         OPPONENT(SPECIES_KADABRA);
     } WHEN {
-        TURN { MOVE(playerLeft, MOVE_MIND_BLOWN, criticalHit:FALSE); }
+        TURN { MOVE(playerLeft, MOVE_MIND_BLOWN, criticalHit: FALSE); }
     } SCENE {
         HP_BAR(playerLeft, hp: 0);
         ANIMATION(ANIM_TYPE_MOVE, MOVE_MIND_BLOWN, playerLeft);