Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all mon elevation changes in #2021 were actually applied #2808

Open
AsparagusEduardo opened this issue Mar 7, 2023 · 3 comments
Open
Labels
category: sprite-issue Issues with a Pokémon's sprite/palette

Comments

@AsparagusEduardo
Copy link
Collaborator

Major screw up on my part

@hedara90 hedara90 added the category: sprite-issue Issues with a Pokémon's sprite/palette label Jul 26, 2024
@hedara90
Copy link
Collaborator

Is this issue still relevant?
When I looked through all sprites for #5178 I didn't see anything that looked incredibly off.

@AsparagusEduardo
Copy link
Collaborator Author

Is this issue still relevant? When I looked through all sprites for #5178 I didn't see anything that looked incredibly off.

I should've been more clear on what I mean by this.
On merrp's branch, there was this PR that adjusted the elevation of overworld sprites so that they're aligned to the player's "floor":
aarant#13

I had to use Rahtak's sprites from Team Aqua's Resource Repo in order to generate palettes via script, hence why they didn't have these changes.

@AsparagusEduardo
Copy link
Collaborator Author

AsparagusEduardo commented Aug 22, 2024

Ah, i realize that this issue was duplicated. I'm posting the other issue's description that's more complete here #4776

Because of that, some sprites currently feel like they are positioned incorrectly compared to the player.

Should we add something to the Sprite Visualizer to indicate the "floor" they're relative to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: sprite-issue Issues with a Pokémon's sprite/palette
Projects
None yet
Development

No branches or pull requests

2 participants