Add in-battle shadows underneath all enemy battlers

[lhearachel]

This adds a configurable option to display blob-shadows underneath all enemy battlers.

Description

These changes add new data-fields to the SpeciesInfo struct defining where to position the shadow and what size blob-shadow to draw. All species through Generation 9 are updated with new values. The sprite visualizer has also been updated to support previewing changes to this data for a given species.

All changes to the code controlling how shadow sprites are constructed are masked behind B_ENEMY_MON_SHADOW_STYLE.

Images

Feature(s) this PR does NOT handle:

1. Enemy battlers that are fainting have their shadow disabled due to a branch in SpriteCB_EnemyShadow; the routine IsBattlerSpritePresent will return FALSE before the battler's fainting animation begins, causing the shadow to be hidden during the fainting cry.
2. Pokemon that are the target of any animation (including the catching animation) will have their shadow disabled during the ball-throw animation. This is due to gAnimScriptActive being set to TRUE during the Sprite callback.

Discord contact info

lhea

[hedara90]

The build fails for me if I try to compile the rom with B_ENEMY_MON_SHADOW_STYLE set to GEN_3.
error: 'struct BattleHealthboxInfo' has no member named 'shadowSpriteIdLeft'; did you mean 'shadowSpriteId'
Getting 8 of those errors.

[lhearachel]

The build fails for me if I try to compile the rom with B_ENEMY_MON_SHADOW_STYLE set to GEN_3.

Fixed those errors, albeit in a bit of an ugly fashion. I think it would be good to revisit how the sprites themselves are laid out to lessen the preproc reliance (maybe always use left and have right be an extra sprite for gen4?), but I'm not certain on the approach.

[hedara90]

Looked at all shadows.
Found some that I think are just oversights.
More that are personal opinions.
Other than that I think it looks good. But the code this touches isn't my strongest area. Couldn't find anything obviously broken.

[hedara90]

With B_ENEMY_MON_SHADOW_STYLE set to GEN_3, if the first pokemon to be sent out by an enemy trainer has a shadow under GEN_3 rules, the shadow is present before the pokemon is sent out.

shadow.mp4

[AlexOn1ine]

I remember that this pr went from using preprocs to normal if conditions. The answer is probably buried somewhere here but why was it reverted to using the preproc again?

[hedara90]

All functionality seems to be in order now.
Everything I've tested works with both Gen 3 and later gen settings.
The only thing is some whitespace changes.