Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsMoveEffectInPlus wrong stat Id check #5197

Closed
ghoulslash opened this issue Aug 18, 2024 · 0 comments · Fixed by #5366
Closed

IsMoveEffectInPlus wrong stat Id check #5197

ghoulslash opened this issue Aug 18, 2024 · 0 comments · Fixed by #5366
Labels
bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet

Comments

@ghoulslash
Copy link
Collaborator

Description

https://github.com/rh-hideout/pokeemerald-expansion/blob/e4c81ba6e0fb353589262869b09f7fac4bf87c5c/src/battle_ai_util.c#L848> should read if (ShouldLowerStat(battlerDef, STAT_ATK + (gMovesInfo[move].additionalEffects[i].moveEffect - MOVE_EFFECT_ATK_MINUS_2)) && noOfHitsToKo != 1) instead (MOVE_EFFECT_ATK_MINUS_1 --> MOVE_EFFECT_ATK_MINUS_2)

Version

1.9.0 (Latest release)

Upcoming/master Version

No response

Discord contact info

No response
@ghoulslash ghoulslash added bug Bug status: unconfirmed This bug has not been reproduced yet category: battle-ai Pertains to Battle Engine Upgrade's AI labels Aug 18, 2024
@Pawkkie Pawkkie mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IsMoveEffectInPlus stat Id fix Pawkkie/pokeemerald-expansion
1 participant
@ghoulslash