IsMoveEffectInPlus stat Id fix #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pawkkie
added
category: battle-ai
AlexOn1ine
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Full credit to @ghoulslash for this I'm just PRing it.
In
AI_IsMoveEffectInPlus, the check for move effects that lower stats by 2 stages uses the incorrect effect Id. WhenShouldLowerStatis called, it knows what stat to reference by offsetting the move effect such that it relates to the 0 - 6 scale of Pokemon stats.This works as intended for the cases where single stage effects are offset by
MOVE_EFFECT_ATK_MINUS_1, but two stage effects are also offset byMOVE_EFFECT_ATK_MINUS_1when they should be offset byMOVE_EFFECT_ATK_MINUS_2. This PR just corrects that offset.Issue(s) that this PR fixes
Fixes #5197
People who collaborated with me in this PR
@ghoulslash for identifying / fixing, I'm just PRing it and explaining it for posterity.
Discord contact info
@Pawkkie