Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mega evolution may change order #1914

Closed
wants to merge 13 commits into from
Closed

Mega evolution may change order #1914

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
818d6fa
(Trying to) Mega Evolution may change turn order the turn it mega evo…
kleeenexfeu Nov 17, 2021
80c14c6
Add comment
kleeenexfeu Nov 17, 2021
648be27
Add config
kleeenexfeu Nov 17, 2021
902d787
Typos and suggestions for the name
kleeenexfeu Nov 17, 2021
7eb8f39
Comment
kleeenexfeu Nov 17, 2021
302f76c
typo
kleeenexfeu Nov 17, 2021
da38427
comment fix
kleeenexfeu Nov 17, 2021
8942d90
update func name
kleeenexfeu Nov 17, 2021
52a2dcb
consistency
kleeenexfeu Nov 17, 2021
763e267
typo
kleeenexfeu Nov 17, 2021
577cce1
brackets
kleeenexfeu Nov 17, 2021
53118df
variable decalaration
kleeenexfeu Nov 17, 2021
07538b7
This syntax looks cleaner for the config
kleeenexfeu Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/constants/battle_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@
#define GEN_8 5
#endif

// Mega Evolution settings
#define B_MEGA_INFO_CHANGE_ORDER GEN_7 // In gen6, mega evolving doesn't change the turn order the turn you mega evolve. This is fixed in gen 7
Copy link
Collaborator

@LOuroboros LOuroboros Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define B_MEGA_INFO_CHANGE_ORDER GEN_7 // In gen6, mega evolving doesn't change the turn order the turn you mega evolve. This is fixed in gen 7
#define B_MEGA_EVOLUTION_TURN_ORDER GEN_7 // In Gen7, a Pokémon's Speed after Mega Evolution is used to determine turn order, not its Speed before.


// Calculation settings
#define B_CRIT_CHANCE GEN_7 // Chances of a critical hit landing. See CalcCritChanceStage.
#define B_CRIT_MULTIPLIER GEN_7 // In Gen6+, critical hits multiply damage by 1.5 instead of 2.
Expand Down