Gen 8 EXP Candies #2142
Merged
Gen 8 EXP Candies #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 03c21c3.
|
What happened to all the moves that it would have learned between levels 8 and 24? |
Resolved! |
LOuroboros
requested changes
May 16, 2022
LOuroboros
reviewed
May 16, 2022
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
Sneed69
suggested changes
May 16, 2022
Co-authored-by: sneed <56992013+Sneed69@users.noreply.github.com>
Sneed69
reviewed
May 17, 2022
Co-authored-by: sneed <56992013+Sneed69@users.noreply.github.com>
|
Spherical Ice pointed out that this defines should have some parentheses |
src/pokemon.c
Outdated
| @@ -4885,15 +4885,15 @@ bool8 PokemonUseItemEffects(struct Pokemon *mon, u16 item, u8 partyIndex, u8 mov | |||
| if (param == 0xFF) // Rare Candy | |||
| { | |||
| dataUnsigned = gExperienceTables[gBaseStats[GetMonData(mon, MON_DATA_SPECIES, NULL)].growthRate][GetMonData(mon, MON_DATA_LEVEL, NULL) + 1]; | |||
| SetMonData(mon, MON_DATA_EXP, &dataUnsigned); | |||
| CalculateMonStats(mon); | |||
There was a problem hiding this comment.
Why did you move this so it only sets the EXP with Rare Candies and not Exp. candies?
AsparagusEduardo
requested changes
Aug 25, 2022
LOuroboros
requested changes
Aug 26, 2022
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
AsparagusEduardo
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates EXP Candies with Rare Candies, with
holdEffectParamused to distinguish them.Discord Contact Info
Agustin#1522