Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoadSpecialPokePic adjustments #2247

Merged
merged 1 commit into from
Aug 25, 2022
Merged

LoadSpecialPokePic adjustments #2247

merged 1 commit into from
Aug 25, 2022

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

  • Simplified LoadSpecialPokePic (fixes HandleLoadSpecialPokePic needs an update #1948).
  • Changed most gender difference flag checks to use the new function ShouldShowFemaleDifferences.
  • Removed redundant functions used only for pokemon_debug.c
    • HandleLoadSpecialPokePicCustom
    • CreateMonIconCustom
    • LoadSpecialPokePicCustom
    • GetMonIconPtrCustom
    • GetMonIconTilesCustom

I wanted to also fix #2246, but that may be caused by something else in pokemon_debug.c.

Discord contact info

AsparagusEduardo#6051

@AsparagusEduardo
Multiple changes
af137c9 
- Simplified LoadSpecialPokePic
- Changed all checks flag checks to houldShowFemaleDifferences
@ghoulslash ghoulslash merged commit 15a3681 into rh-hideout:master Aug 25, 2022
@AsparagusEduardo AsparagusEduardo deleted the RHH_specialPic branch August 25, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoulslash ghoulslash ghoulslash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pokémon Debug isn't loading female icon palettes correctly HandleLoadSpecialPokePic needs an update
2 participants
@AsparagusEduardo @ghoulslash