Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tidies
graphics/battle_anims
by moving out graphics used from thenew
folder and discard what's not used.======= NOTES =======
graphics/battle_anims/backgrounds/new/psychic.pal
renamed tographics/battle_anims/backgrounds/psychic_new
may require an ifdef, detail here.
I personally against the idea of adding an ifdef for a simple palette swap, if we are ifdef ing this.
Psychic background should at least be updated with Gen4 graphic
graphics/battle_anims/sprites/new/green_star
is not new at all, at first glance it is just a copy of vanillagreen_star
#if B_NEW_MORNING_SUN_STAR_PARTICLE
should be erased if so.Renamed into
green_star_new
for now, detail here.graphics/battle_anims/sprites/new/impact
renamed tographics/battle_anims/sprites/impact_new
graphics/battle_anims/sprites/new/horn
renamed tographics/battle_anims/sprites/horn_hit_new
gBattleAnimSpriteGfx_NewHornHit is not used anywhere and can be safely erased.
gBattleAnimSpritePal_NewHornHit however, is just a minor modified vanilla gBattleAnimSpriteGfx_HornHit
Making
B_NEW_HORN_ATTACK_PARTICLE = TRUE
useless since there will be no palette swap at all.It doesn't stop there, gBattleAnimSpritePal_NewHornHit is actually just
impact_new.pal
We truly live in a society.
An ifdef for
B_NEW_HORN_ATTACK_PARTICLE
is required in this code to make it actually do something whenB_NEW_HORN_ATTACK_PARTICLE
is set to TRUEgraphics/battle_anims/sprites/new/rocks
renamed tographics/battle_anims/sprites/rocks_new
graphics/battle_anims/sprites/new/spikes
renamed tographics/battle_anims/sprites/spikes_new
practically just a palette swap of vanilla spikes, so gBattleAnimSpriteGfx_NewSpikes is not really needed.
graphics/battle_anims/sprites/new/substitute_front
renamed tographics/battle_anims/sprites/substitute_new
graphics/battle_anims/sprites/new/substitute_back
renamed tographics/battle_anims/sprites/substitute_back_new
graphics/battle_anims/sprites/new/sword
renamed tographics/battle_anims/sprites/sword_new
graphics/battle_anims/sprites/new/teeth
renamed tographics/battle_anims/sprites/teeth_new
graphics/battle_anims/sprites/new/thrash
renamed tographics/battle_anims/sprites/new/hands_and_feet_new
ifdef is
B_NEW_HANDS_FEET_PARTICLE
.======= DISCARDED FILES =======
backgrounds/new/tectonic_rage.bin
sprites/new/ detailed in here.