Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi battles where Trainer has only one mon #2670

Merged

Conversation

DizzyEggg
Copy link
Collaborator

Fixes #2573

@pkmnsnfrn
Copy link
Collaborator

This fixes the reported bug, but creates a new one where the 2nd Pokemon in an actual double battle is invisible.

CleanShot 2023-02-16 at 09 03 50

@DizzyEggg
Copy link
Collaborator Author

@pkmnsnfrn Nice catch, should be good now

@pkmnsnfrn
Copy link
Collaborator

VuWJASd 1

Thanks for the fix @DizzyEggg! (and thanks for the ping @Jaizu)

@Jaizu
Copy link

Jaizu commented Feb 26, 2023

Imo, when playing multiple pokémon vs the enemy (aka 2vs1), if the enemy only has 1 Pokémon on its party is should have loaded the singles ui for the enemy, as well as the enemy pokémon coordinates (is too moved to the right)

@AsparagusEduardo
Copy link
Collaborator

Imo, when playing multiple pokémon vs the enemy (aka 2vs1), if the enemy only has 1 Pokémon on its party is should have loaded the singles ui for the enemy, as well as the enemy pokémon coordinates (is too moved to the right)

I agree. This is already handled on the player's side when the opponent has 2 mon against your 1, so the same should happen on the other side.

@DizzyEggg
Copy link
Collaborator Author

@Jaizu @pkmnsnfrn
I applied your suggestion

@AsparagusEduardo AsparagusEduardo merged commit ae80d54 into rh-hideout:upcoming Apr 20, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
@DizzyEggg DizzyEggg deleted the fix_one_mon_enemy_double branch June 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multi battles against a Trainer with a singular Pokémon in their party
4 participants