Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to Trainer Slide messages #2699

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

DizzyEggg
Copy link
Collaborator

Fixes #2693
Fixes #1655

Note:
The issue Lunos submitted covers many topics. In this PR I only fixed graphical glitches and the feature not functioning properly in doubles.
Once it's merged, I believe it would be best to have two new issues:

  • the first one for the trainer sprite appearing on the mon sprite in doubles, not glitchy, but looks weird, could be improved
  • making the slide messages appear at the same moments as in the games, that is adding a super effective field and changing 25% msg to 50%(or having both, that's subject to discussion and change)

@DizzyEggg DizzyEggg merged commit 44d2cc7 into rh-hideout:upcoming Feb 27, 2023
@DizzyEggg DizzyEggg deleted the trainer_slide branch February 27, 2023 08:11
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants