Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Ceaseless Edge/Axe Kick visual glitch #2969

Merged
merged 1 commit into from
May 2, 2023

Conversation

AlexOn1ine
Copy link
Collaborator

Description

Fixes Ceaseless Edge and potentially Axe Kick (move effect not done yet).
There was a 'visual' bug after Ceaseless Edge was used to faint a mon because the move didn't end correctly.

Images

CEASELESS_EDGE

Issue(s) that this PR fixes

Fixes #2958

Discord contact info

AlexOnline#2331

@AsparagusEduardo
Copy link
Collaborator

Looking at the change makes me think that the Spikes and Stealth Rock would break from it.

@AlexOn1ine
Copy link
Collaborator Author

Looking at the change makes me think that the Spikes and Stealth Rock would break from it.

Yeah, this is what I also thought and my draft had it but, unless I am missing something, the two scripts I changed are used independent of the moves Spikes and Stealth Rock. Both of these moves have dedicated scripts.

@AsparagusEduardo
Copy link
Collaborator

Yeah, this is what I also thought and my draft had it but, unless I am missing something, the two scripts I changed are used independent of the moves Spikes and Stealth Rock. Both of these moves have dedicated scripts.

Did you test them manually to make sure?

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented May 2, 2023

Yeah, this is what I also thought and my draft had it but, unless I am missing something, the two scripts I changed are used independent of the moves Spikes and Stealth Rock. Both of these moves have dedicated scripts.

Did you test them manually to make sure?

Yeah, only spikes though. Works fine. Can also test Stealth Rock though.

/Edit: Stealth Rock

stealth_rock

@AsparagusEduardo AsparagusEduardo merged commit 957ee36 into rh-hideout:upcoming May 2, 2023
@AlexOn1ine AlexOn1ine deleted the ceaseless_edge branch May 13, 2023 19:40
@AsparagusEduardo AsparagusEduardo mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The enemy Trainer does not faint properly when Ceaseless Edge is used
2 participants