Fix shiny animation not respecting Illusion mon target and Imposter revealing opponent ability #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ultimate-Bob
changed the title
|
While I'm at it, this also fixes #2946. If an Illusion user is in the last slot of the party, its Illusion will no longer activate when sent out.
|
AsparagusEduardo
approved these changes
May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an Illusion user is sent out, the shiny animation (stars) does not respect the shininess of the illusion target (which of course ruins the illusion...☹️ )
This fix will instead use the result of
GetIllusionMonPtrif it is non-null.This also fixes #2971 - the Imposter ability no longer reveals the ability of the opponent in the ability popup and instead properly shows 'Imposter'.
Images
Illusion
Imposter
Discord contact info
Ultimate_Bob#2163