Killed the bKGD invalid index warnings and fixed the bit depth of the species sprites #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special thanks to: -Blackforest for the tips on how to go about fixing the sprites with GIMP. -Dat.S.H for a tip on how to make the conversion process easier to perform. -Psf for actually going and doing it.
LOuroboros
changed the title
ghoulslash
approved these changes
Jun 24, 2023
This was referenced Jun 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Back in #2735, I processed a good number of sprites in the project using Aseprite in order to kill the bKGD warnings that most of them were producing while building a ROM.
This had the unfortunate consequence of modifying the bit depth of those sprites, setting it to 8 instead of the default which is 4.
@Blackforest92 pointed that out to me recently, and also told me a way to address it using GIMP.
Combined with the fact that there were about 21 new sprites (all of them belonging to Hisuian forms) that also triggered the bKGD warning, this led me to decide to batch process all the species sprites of the project following Blackforest's tips.
Since my computer processed the sprites too slowly though, @pkmnsnfrn decided to lend me a hand and process the sprites by themself, using a plugin that was suggested to us by @SonikkuA-DatH.
The result?
All the Pokémon species sprites have a bit depth of 4bpp as they should, none of them trigger a bKGD warning, and surprisingly, they're smaller than they were before in terms of file size.
I checked very quickly the sprites of the 1st generation, both, normal and shiny palettes, and I didn't notice anything wrong at a glance.
Discord contact info
Lunos#4026