Detect test runner crashes #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgriffin
force-pushed
the
rhh-detect-crash
branch
from
a999e0f to
34378af
Compare
|
Please let me know before merging so I can rebase :) |
SBird1337
reviewed
Jul 14, 2023
mrgriffin
force-pushed
the
rhh-detect-crash
branch
from
bd70dde to
611096a
Compare
mrgriffin
force-pushed
the
rhh-detect-crash
branch
from
611096a to
25986be
Compare
|
Rebased :) |
SBird1337
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores some information at the bottom of the IRQ stack. The IRQ stack is not cleared in
crt0.s/main.c, which means that even if the game resets the values will still be there. We use this to report that the current test crashed, and resume running the tests from the next test.I cannot stress strongly enough that
.persistentshould not be used because the IRQ stack is tiny. (The name was taken from Crater's ld script proposal).