Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Protosynthesis and Quark Drive boosts #3139

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

AlexOn1ine
Copy link
Collaborator

Currently both Atk/Sp.Atk and Def/Sp.Def are boosted if either of them is the highest stat.
This should fix it.

Images

Protosynthesis Nidoqueen.
Before:
pokeemerald-15
After:
pokeemerald-14

Discord contact info

rainonline

MulModifier(&modifier, UQ_4_12(0.7));
}
break;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-add that break;.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh...

Fixed it.

@DizzyEggg
Copy link
Collaborator

I'd like to see a test added for this 👀

Add unintentionally deletet break

new line
@AlexOn1ine AlexOn1ine force-pushed the protosynthesis_quarkdrive branch 2 times, most recently from f030921 to 77ba18d Compare July 16, 2023 12:46
@AlexOn1ine
Copy link
Collaborator Author

Added tests and fixed a bug I introduced. The Tests fail without this PR.

Also might be a good Idea to replace the mons once gen9 species are merged.

@DizzyEggg DizzyEggg merged commit 330e20b into rh-hideout:master Jul 17, 2023
@AlexOn1ine AlexOn1ine deleted the protosynthesis_quarkdrive branch July 19, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants