Battle tests for Poison Heal, Sap Sipper and Defeatist #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsparagusEduardo
requested changes
Jul 30, 2023
| } WHEN { | ||
| TURN { MOVE(opponent, MOVE_VINE_WHIP); } | ||
| } SCENE { | ||
| NONE_OF { HP_BAR(player); } |
There was a problem hiding this comment.
Let's add the canceling move messages at least.
There was a problem hiding this comment.
There is no explicit canceling message, since it flows into the "increases Attack" tests
There was a problem hiding this comment.
Then let's add the regular messages to make it explicit how the messaging shows up. I had to look up a video to make sure.
|
Since this is from July and also targetting upcoming, I'll make a fresh PR for this and include some more tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for Sap Sipper and Defeatist, which were working as expected.
Adds tests for Poison Heal, which was lacking the Ability pop-up (hereby added).
Discord contact info
bassoonian