Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Wailord icon sprite #3183

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Fixed Wailord icon sprite #3183

merged 1 commit into from
Jul 30, 2023

Conversation

SubzeroEclipse
Copy link

Description

Moved it one pixel upwards to prevent it from wrapping around.

Images

wailord

Issue(s) that this PR fixes

Fixes #3077

Discord contact info

subzeroeclipse

@pkmnsnfrn
Copy link
Collaborator

OH MY GOD i thought this was a bug with my start menu tysm

@LOuroboros LOuroboros changed the title Fixed Wailord mini sprite Fixed Wailord icon sprite Jul 30, 2023
AsparagusEduardo
AsparagusEduardo approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have the fix, though I think I'll open a separate issue on how icon rendering is handled, since this might be a vanilla bug that never manifested due to their icons never being so big.

@AsparagusEduardo AsparagusEduardo merged commit c76e5de into rh-hideout:upcoming Jul 30, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request Jul 30, 2023
Closed
@pkmnsnfrn
Copy link
Collaborator

Just had a thought. Does this undo Jaizu's work on centering? #2879

@AsparagusEduardo
Copy link
Collaborator

Just had a thought. Does this undo Jaizu's work on centering? #2879

Meets it half-way, Jaizu's PR moved the sprite 2 pixels down, while this PR raises it 1 pixel up.

@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Merged
@SubzeroEclipse SubzeroEclipse deleted the wailord branch December 6, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SubzeroEclipse @pkmnsnfrn @AsparagusEduardo