Made Cmd_jumpifnopursuitswitchdmg and Cmd_pursuitdoubles use Pursuit's effect ID instead of its move ID #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOuroboros
changed the title
AsparagusEduardo
approved these changes
Aug 14, 2023
|
Sorry. I clicked the button to delete the branch out of habit, without noticing that you already had deleted it Eduardo 🤣 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For whatever reason, right now the expansion's
Cmd_jumpifnopursuitswitchdmgbattle script function (which handles the usage of Pursuit when an opponent is about to switch out their Pokémon) uses Pursuit's move ID instead of its effect ID.This is a bit limiting for a user who may very well want to add add copies/clones of Pursuit, as they would have to go there and modify things by themselves.
This PR addresses that by making the function read the effect of Pursuit, which is
EFFECT_PURSUIT, instead of hardcodinggCurrentMoveto Pursuit's move ID. That way, any moves that a user may want to add and that also use that same effect besides Pursuit itself can work normally too.Discord contact info
lunos4026