Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Substitute doll sprites #3263

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented Aug 29, 2023

Description

Updates the Substitute doll sprite, like is being done to the Pokemon.
Front sprite is taken from gen 5, while back sprite is custom by CyanSixFour based on gen 4 and gen 5.

Images

image

Discord contact info

kittenchilly

@kittenchilly kittenchilly marked this pull request as ready for review August 29, 2023 22:57
@AsparagusEduardo
Copy link
Collaborator

I didn't realize that the new already existed. Why not update that one instead and fix it so that it's read via the other particle configs?

@kittenchilly
Copy link
Author

I didn't realize that the new already existed. Why not update that one instead and fix it so that it's read via the other particle configs?

I was thinking it'd be treated the same as Pokemon sprites, without any config. I don't think people would want the old substitute sprite if they have to use new pokemon sprites.

@AsparagusEduardo
Copy link
Collaborator

I was thinking it'd be treated the same as Pokemon sprites, without any config. I don't think people would want the old substitute sprite if they have to use new pokemon sprites.

We also want to eventually have that as a config as well, but we're currently restricted by how graphics are loaded.

@kittenchilly
Copy link
Author

We also want to eventually have that as a config as well, but we're currently restricted by how graphics are loaded.

Hm ok I'll add the config back then

@kittenchilly
Copy link
Author

kittenchilly commented Aug 30, 2023

Hm ok I'll add the config back then

Actually, originally the config was only for the monster doll particle, which seems unused. Not sure if it'll work for the actual substitute sprite
It may be better to revisit this once we add the other pokemon sprites config

@AsparagusEduardo
Copy link
Collaborator

Hm ok I'll add the config back then

Actually, originally the config was only for the monster doll particle, which seems unused. Not sure if it'll work for the actual substitute sprite It may be better to revisit this once we add the other pokemon sprites config

Alright, makes sense to me. Do you have another back sprite for it? The vanilla back size looks too small to me. If not, lowering the sprite a bit would help as well

@kittenchilly
Copy link
Author

New backsprite by CyanSixFour has been added thats a combination of the gen 4 and gen 5 ones, looks great
image

@AsparagusEduardo
Copy link
Collaborator

Question, why 2 different palettes for the front and back?

@kittenchilly
Copy link
Author

Question, why 2 different palettes for the front and back?

I tried giving both sprites the same palette and it didn't work correctly, so I just gave them different palettes.

@Jaizu
Copy link

Jaizu commented Sep 1, 2023

This file contains the 3 sprites and its .pal file, they all use the same pal.
Substitute.zip

image

@kittenchilly
Copy link
Author

This file contains the 3 sprites and its .pal file, they all use the same pal. Substitute.zip

image

This worked perfectly, thanks. PR should be complete and reviewable now.

@AsparagusEduardo
Copy link
Collaborator

Looks good, please solve conflicts.

@kittenchilly
Copy link
Author

kittenchilly commented Sep 4, 2023

Looks good, please solve conflicts.

Done

@AsparagusEduardo AsparagusEduardo merged commit 2fa4206 into rh-hideout:upcoming Sep 4, 2023
@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants