Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wall errors in the codebase #3267

Closed
wants to merge 9 commits into from

Conversation

DizzyEggg
Copy link
Collaborator

Fixes all(or part) of the currently occurring errors in our codebase. This is the next step after #3165 in our quest to ditch agbcc.

Some notes:

  • Turns out there were a couple of actual errors/UBs in our code(i.e. see IncreaseStatUpScore changes). They are fixed now.
  • Unused GF's function use the unused attribute now. Dummies/dumb functions are removed. Unused functions written by us are commented out.
  • I had to, and probably will have to still do, do some ugly casts/memcpy calls to get around strict aliasing and signedness
  • There were lots of non-void functions without a return statement and unused or just set variables in functions.

@DizzyEggg DizzyEggg changed the title Fix Wall / Wextra errors in the codebase Fix Wall errors in the codebase Sep 1, 2023
@DizzyEggg DizzyEggg marked this pull request as ready for review September 4, 2023 14:19
@DizzyEggg
Copy link
Collaborator Author

This is, in theory, complete. I might have made some questionable decisions with how I handled some compiler errors, so I'm open to discussion.
Things like changing s16 to u16 or u16 to s16 should be tested as things may break there. They already did for me once with the door animations(fixed now.)

@DizzyEggg
Copy link
Collaborator Author

au revoir 3267

@DizzyEggg DizzyEggg closed this Oct 13, 2023
@DizzyEggg DizzyEggg deleted the errors_modern branch October 13, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant