Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Level Caps #3632

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented Dec 4, 2023

Level Caps

Hard Caps

  • No explanation need. Once you reach a certain threshold you can't go above it.

Soft Caps

  • Once cap is reached you still get exp with diminishing returns. Some defaults are given but it's fully customizable.

Rare Candy toggle

  • Rare Candies allow to bypass the level cap unless B_RARE_CANDY_CAP is set to true.

Level Cap type

  • Level caps can be set with a flag or variable. An example is given for flags with Emerald level caps. For the variable an event var is needed.

Credits to SBird for initial outline and PokemonCrazy for soft caps, though I deviated from their implementation.

@AsparagusEduardo AsparagusEduardo added this to the 1.8.0 milestone Dec 4, 2023
@PCG06
Copy link

PCG06 commented Dec 5, 2023

Can you try an interaction with EXP candies please?

@AlexOn1ine
Copy link
Collaborator Author

Can you try an interaction with EXP candies please?

Can't be used if B_RARE_CANDY_CAP is set.

include/level_caps.h Outdated Show resolved Hide resolved
src/level_caps.c Outdated Show resolved Hide resolved
src/level_caps.c Outdated Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator Author

Reviews applied 👀

@katykat5099
Copy link

@AlexOn1ine there are level caps in thexamans challenges.

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Jan 5, 2024

@AlexOn1ine there are level caps in thexamans challenges.

I haven't looked into thexamans version level caps but this one extensively covers all cases that users can easily choose from so I would prefer this one. You could just adjust your branch to use these level caps.

@Bassoonian Bassoonian dismissed DizzyEggg’s stale review January 9, 2024 17:47

"feel free to merge"

@Bassoonian Bassoonian merged commit c56acb9 into rh-hideout:upcoming Jan 9, 2024
1 check passed
Beartime234 pushed a commit to Beartime234/pokemon-kessoku that referenced this pull request Mar 16, 2024
* New Feature: Level Caps

* B_LEVEL_CAP_EXP_UP and fixes

* 1 exp fix for hard level caps

* remove 1 exp hack

* Reviews applied

* fix u8/u16

---------

Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
@zsd7200
Copy link

zsd7200 commented Mar 18, 2024

hey, PokemonCrazy here! thank you for putting this in! just saw this in the release and freaked out seeing my name in the release notes lol

i was just getting back into my project after like 3 years of being dormant and planned to clean this code up a bit but now i can just use this, this is awesome :)

@AlexOn1ine AlexOn1ine deleted the level_caps branch November 21, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants