Fix form change table pointer defines #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgriffin
approved these changes
Dec 11, 2023
Comment on lines
+19
to
+20
| #endif //P_FAMILY_SOLGALEO | ||
| #if P_FAMILY_LUNALA |
There was a problem hiding this comment.
These should be P_FAMILY_COSMOG. As they are, they're disabled since there's no Solgaleo/Lunala toggles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the generational defines in the form change table pointer defines with family-based defines. I don't think I currently have the ideal solution since this is all rather finicky, and we should probably include
P_FUSION_FORMSin here too, but it quickly turns into a config fest. Thoughts are very welcome!Issue(s) that this PR fixes
Fixed #3691
Discord contact info
bassoonian