Fix Ion Deluge interaction with VoltAbsorb/LightRod #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Dec 18, 2023
src/battle_script_commands.c
Outdated
| @@ -8324,7 +8289,7 @@ static bool32 IsAbilityAbsorbAffected(void) | |||
| else | |||
| moveType = gBattleMoves[gCurrentMove].type; | |||
|
|
|||
| if (moveType == TYPE_ELECTRIC && GetBattlerAbility(gBattlerTarget) == ABILITY_VOLT_ABSORB) | |||
| if (moveType == TYPE_ELECTRIC && GetBattlerAbility(gBattlerTarget) == ability && gBattleMoves[gCurrentMove].effect != EFFECT_ION_DELUGE) | |||
There was a problem hiding this comment.
Maybe target MOVE_TARGET_ALL_BATTLERS would be better instead of the effect so that it applies to all future moves with a similar effect?
There was a problem hiding this comment.
You're absolutely right, this also works for Electric Terrain which my fix didn't include.
There was a problem hiding this comment.
Tests fail. I guess it's because it also needs to check for type?
There was a problem hiding this comment.
Teatime tests failing, I guess it won't be this simple after all 🤔
There was a problem hiding this comment.
Alright, should be good now
AlexOn1ine
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3683