Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Battle Move "Split" to the proper "Category" #3774

Merged

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Also removed unused asm/macros/battle_ai_script.inc.

Images

stop-me

Discord contact info

AsparagusEduardo

@cfmnephrite
Copy link

Rejected because you should be on vacation

@DizzyEggg
Copy link
Collaborator

What's the reasoning behind this actually? Isn't split coined as a term for physical / special moves? Category seems a bit vague. 🤔

@Bassoonian
Copy link
Collaborator

Split is the fan term, the officialy terminology is indeed category. https://bulbapedia.bulbagarden.net/wiki/Damage_category

@Bassoonian Bassoonian merged commit 442620c into rh-hideout:upcoming Dec 20, 2023
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/upcoming/splitCategory branch December 20, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants