Seed the RNG with the time in seconds in HQ mode #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgriffin
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
lgtm
Two minor comments that aren't blocking:
SeedRngcan't be conveniently stored in a function pointer because its type varies. An alternative would have been to always take au32, and then cast it tou16inside the non-HQ implementation.ConvertBcdToBinaryconverts invalid numbers into0xFFand then reports an error, whereasBCDblindly plows on. I doubt this matters either, if the RTC is non-functional then just seeding to some consistent value doesn't seem like a problem. (I suppose in the future if somebody wants to be broken-RTC-proof they could mix in a frame count)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In HQ mode, SeedRng() and SeedRng2() now take 32 bit arguments. SeedRngWithRtc() now generates the number of seconds on the RTC, which I think provides 3.something billion seed values. u16 arguments would be zero-extended, which matches the old behavior.
Discord contact info
tertu