Fix debug menu flags not redrawing correctly after PR 3796 #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Jan 3, 2024
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
Bassoonian
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After PR 3796 was merged, now the flag toggles in the debug menu now no longer reflect the current state of the flag when you toggle them. Basically when you toggle a flag on, it doesn't update the color to reflect it and it ends up "flipped" from what it really should be, because it's getting redrawn before the function runs to toggle the flag.
This PR changes when the redraw happens relative to the function itself depending on which option is selected. This way the menu renders properly both when toggling a flag and viewing all the flags/vars in the debug menu.
This is kind of a silly fix, but it's the best way I could think of. Let me know if y'all have a better way to write this in mind.
Images
No gif included because without inputs visible it doesn't make sense.
Discord contact info
Discord user: ravepossum