Adds Clanging Sclaes test, reverts fix and few Parental Bond tests #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Bassoonian
approved these changes
Jan 11, 2024
|
Some small clarification. @damon-murdoch fixed a z-move bug but I wrote the test for the normal Kommo-o signature move. I'm not sure if we can test z moves by now. If we can, I'll write a new one. it's all fine in-game. Still removing the line from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a PR was made the should have fixed Clanging Scales but a proper test didn't confirm the fix.
Technically Defense drop happened only once but after the first hit, making the second hit weaker. This will be fixed in PR #3577 since the behaviour was refactored to drop a stat after all hits happened.
@damon-murdoch I had to revert the fix for now. Please don't be discouraged by PR'ing bug fixes in the future 😄
Also I took over #3606. Though I deleted one test because it seemed like a duplicate to me.