Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few new gen 9 move animations #3989

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented Jan 13, 2024

A couple New gen9 animations made by @ZnogyroP with improvment suggestions by @ghoulslash and adjustments by me.
Also replaced old Draco Meteor (I am not sure who made the old anim but I hope the replacement is okay by everyone) animation with the CFRU one, Credits to @Skeli789

Raging Bull:

raging_bull.mp4

Gigaton Hammer:

giga_hammer.mp4

Ice Spinner:

ice_spinner.mp4

Aqua Cutter:

aqua_cutter.mp4

Made some minor adjustments to the Double Shock anim I previously PR'd. I wasn't happy with it and I think it's marginally better now:

double_shock.mp4

@AlexOn1ine AlexOn1ine marked this pull request as draft January 13, 2024 16:07
@AlexOn1ine AlexOn1ine marked this pull request as ready for review January 13, 2024 16:15
@ghoulslash
Copy link
Collaborator

A couple ideas (having not seen the actual GF anims so maybe they will be less true to those):

  1. Aqua Cutter slash should probably be blue-ish and maybe have crabhammer bubbles after/during instead of the waterfall. The blue slash could either be from false swipe or just using AnimTask_BlendParticle
  2. Ice spinner might look better if the ice punch crystal swirl or a crystal swirl using fire spin's callback envelops the attacker as it rapid spins away (either instead or in addition to the bg)
  3. raging bull should maybe have the wind-up from double edge or other slide-back movement

@AlexOn1ine
Copy link
Collaborator Author

A couple ideas (having not seen the actual GF anims so maybe they will be less true to those):

1. Aqua Cutter slash should probably be blue-ish and maybe have crabhammer bubbles after/during instead of the waterfall. The blue slash could either be from false swipe or just using AnimTask_BlendParticle

2. Ice spinner might look better if the ice punch crystal swirl or a crystal swirl using fire spin's callback envelops the attacker as it rapid spins away (either instead or in addition to the bg)

3. raging bull should maybe have the wind-up from double edge or other slide-back movement

Good suggestions! I'll take a look.

@AlexOn1ine AlexOn1ine marked this pull request as draft January 13, 2024 20:52
@ghoulslash
Copy link
Collaborator

Good suggestions! I'll take a look.

Sounds good just let me know if you need help with anything!

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Jan 14, 2024

Suggestions applied:

I've moved the BG to appear slightly later because of the ice crystals but open to removing it altogether.

ice_spinner.mp4

As suggested I used crabhammer at the end and I couldn't get it to work nicely with AnimTask_BlendParticle so I used False Swipe anim.

aqua_cutter.mp4

Added the wind-up from Double Edge and a BG to make it more distinct

raging_bull.mp4

Also I've ported the Draco Meteor anim (single commit) but I have trouble loading the GFX.
pokeemerald-18
For comparison:
image

@ghoulslash
Copy link
Collaborator

I would probably remove the ice BG from ice spinner but its up to you. I would also maybe remove the first one or two of the false swipe slash sprite templates so aqua cutter is a bit 'faster'. Hard to say whats wrong with draco meteor - which sprite template command is that gfx supposed to load from?

@AlexOn1ine AlexOn1ine marked this pull request as ready for review January 16, 2024 15:44
@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Jan 16, 2024

Ready for re-review!

Was able to figure out the problem with Draco Meteor. I don't know who made the old animation but I hope it's okay if I replace it with the one from CFRU (Credits to Skeli).

draco_meteor.mp4

I'm totally fine with removing the BG from Ice Spinner

ice_spinner.mp4

Removed Aqua Cutter slices.

aqua_cutter.mp4

@ghoulslash ghoulslash merged commit 87472d4 into rh-hideout:upcoming Jan 17, 2024
1 check passed
PCG06 pushed a commit to PCG06/pokeemerald that referenced this pull request Jan 25, 2024
* A few new gen 9 move animations

* draco meteor anim

tmp

* applied suggestions

* fix compile

* add more crystals to ice spinner

* further fixes

---------

Co-authored-by: ghoulslash <41651341+ghoulslash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants