Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punchier tera animation #4507

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

Pokabbie
Copy link

@Pokabbie Pokabbie commented May 6, 2024

Description

Adds a punchier animation for terastalizing.

I'm not particularly good at animation, so it basically just mimics the Mega Evolution animation with some different graphics and sound effects.

Images

Before
tera_before

After
tera_after

Discord contact info

@Pokabbie

@kittenchilly
Copy link

If we have a better animation, I don't think we should have the text anymore?

@AsparagusEduardo
Copy link
Collaborator

AsparagusEduardo commented May 6, 2024

If we have a better animation, I don't think we should have the text anymore?

I think it's fine, for clarity.
EDIT: by this, I mean that since we don't have the hats, it's not as visually obvious to tell chat type they changed into.

@Pokabbie
Copy link
Author

Pokabbie commented May 6, 2024

I found in a few playtests of my hack, people got confused by which type it was as some of the UI indicators aren't immediately clear (Especially to players who aren't as big into Pokémon).
So, unless the tera hats are somehow added, keeping the text feels like a necessity imo

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small tweak needed imo. Looks good otherwise 👍

asm/macros/battle_script.inc Outdated Show resolved Hide resolved
src/battle_script_commands.c Outdated Show resolved Hide resolved
src/battle_script_commands.c Outdated Show resolved Hide resolved
@Pokabbie Pokabbie requested a review from AsparagusEduardo May 6, 2024 18:44
@AsparagusEduardo AsparagusEduardo merged commit da3d715 into rh-hideout:upcoming May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants