Fixed regional variant inheritance and pokeball inheritance #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e base species e.g. Persian and Perrserker ball inheritance: fix inheritance for regional forms
Bassoonian
approved these changes
Jun 2, 2024
|
Was ball inheritance not working? I was certain there was another PR that also fixed it #2613 |
|
As far as i can tell that PR only removed a post-creation overwrite of the ball. In CreateHatchedMon the ball was never copied from the egg to the created mon though. Only tested it on FLRG since i don't have access to an emerald save atm., but it should have been functionally identical. |
gotcha, ty for the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regional variants according to https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Regional_forms and https://bulbapedia.bulbagarden.net/wiki/Everstone#Regional_forms
Pokeball inheritance was mostly implemented, but never set for the hatched mon.
Discord contact info
.cawt