Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switching message macros for tests #4717

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Sneed69
Copy link

@Sneed69 Sneed69 commented Jun 3, 2024

Adds two macros to use in tests in place of having to figure out which specific switch-out or send-in message will appear in each situation.

Discord contact info

duke5614

@AsparagusEduardo
Copy link
Collaborator

Non-blocking, but would you be ok with adding a test that checks the conditions for the different messages?

@Sneed69
Copy link
Author

Sneed69 commented Jun 3, 2024

I can't figure out the conditions for the switching out messages.
I am also not sure that it is in the scope of this PR, but I can push just the send-out message test for now.

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's good enough :)

@AsparagusEduardo AsparagusEduardo merged commit 87e2526 into rh-hideout:upcoming Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants