Add config to turn off two-framed front sprites #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, though I want to go through and see what other places is frontAnimFrames referenced. |
|
These are all the occurrences! Duke mentioned another approach that’s slightly more clean on Discord though, so I’ll check and see if that works and replace this one if appropriate |
|
@AsparagusEduardo I think this one can be merged. I've tested it ingame |
AsparagusEduardo
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many Fakemon projects (or projects with extensive respriting), people don't want to bother with second frames for species. Lunos' tutorial on the pret wiki turned off animations in general (including affine animations etc), which may also not be desirable.
This PR adds a config that simple prevents the second frame from ever being shown. It is still compiled into the ROM, but at least it can be safely ignored. This change is extremely non-invasive and trivial to toggle.
Improved implementation by @Sneed69
Discord contact info
bassoonian