Add support for multiple roamers #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3fadaaf.
|
Did you test merging the original branch into a clean upcoming and then merging this PR? |
|
There’s going to be conflicts, but surely that’s unavoidable? I’d rather have a few super easy to solve conflicts than silently overwriting a bunch of features because I solved conflicts for them in a way they presumably don’t want |
Sneed69
reviewed
Jun 11, 2024
AlexOn1ine
reviewed
Jun 12, 2024
|
I increased the roamer count to 10 and couldn't open the dex anymore. /Edit it seems it cleared all dex flags. It worked after I reset them. |
AlexOn1ine
approved these changes
Jun 15, 2024
AsparagusEduardo
added a commit
that referenced
this pull request
Jun 16, 2024
This reverts commit 22994c7.
AsparagusEduardo
added a commit
that referenced
this pull request
Jun 16, 2024
kittenchilly
added a commit
to kittenchilly/pokeemerald-expansion
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily stripped down version of @Sneed69's RoamersPlus, preserving vanilla compatibility in its default state and simply making it far easier to add roamers beyond the initial Latis.
Due to the stripping down, I have opted not to depart from his branch and strip it down from there, as that would cause stripping down for expansion users who previously merged in his full branch and wish to retain its extra functionality.
People who collaborated with me in this PR
@Sneed69
Discord contact info
bassoonian