Added option to disable species cries #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Jun 13, 2024
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
|
Applied |
|
I feel like this option should also remove the cry page on the pokedex, as it will do literally nothing |
|
|
Updated the description |
Bassoonian
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had this made for a bit after some people were asking about it, but myself I don't see it being much useful without determining a "default cry". This PR could be used as a point of discussion as well.
Feature(s) this PR does NOT handle:
Doesn't remove the "cry" page from the pokedexes.
Discord contact info
AsparagusEduardo