Fix Sprite Changing to Female when Terastallizing

[iriv24]

The original issue was that upon terastallizing, a mon's sprite would change to use the female version if a different one was available. I went into the calls to HandleLoadSpecialPokePic and changed the last parameter (personality) from gTransformedPersonalities[battlerAtk] to personalityValue, which is defined a few lines above this call.

Images

See original for GIF with the issue, here is one with the fixed behavior

Issue(s) that this PR fixes

Fixes #4961

People who collaborated with me in this PR

#4961 (comment) -- helpful comment

Feature(s) this PR does NOT handle:

accounting for every other form change case, i am not fully confident that this didnt break something else, someone smarter than me please review this thank you!

Discord contact info

iriv24

[Bassoonian]

Considering you removed a reference to transformed data, are we absolutely sure that Transform/Imposter still correctly represent gender?

[iriv24]

Considering you removed a reference to transformed data, are we absolutely sure that Transform/Imposter still correctly represent gender?

Alright im sure there is a smarter way to go about trying to answer this question, but here's what I've found so far by manually setting up some test scenarios. According to bulbapedia, Ditto, Mew, and Smeargle are the only mons that can get the move Transform, and only Ditto has the ability Imposter. Since Ditto and Mew are both genderless, I assume the tests for Ditto using the move Transform also cover Mew using the move Transform. Lucky for us, Smeargle is gendered, so I set up some tests of different gendered Smeargles Tranforming into different gendered Wobbuffet's.

Transform/Imposter look to still correctly represent gender in the sprite in the following scenarios:

• Player's Ditto (genderless) with Imposter correctly Transforms with the corresponding Male or Female sprite of the Opponent's Wobbuffet
• Player's Ditto (genderless) with Limber uses the move Transform and correctly Transforms with the corresponding Male or Female sprite of the Opponent's Wobbuffet
• Player's Smeargle (Male) uses the move Transform and correctly Transforms with the corresponding Male or Female sprite of the Opponent's Wobbuffet
• Player's Smeargle (Female) uses the move Transform and correctly Transforms with the corresponding Male or Female sprite of the Opponent's Wobbuffet
• Opponent's Ditto (genderless) with Imposter correctly Transforms with the corresponding Male or Female sprite of the Player's Wobbuffet
• Opponent's Ditto (genderless) with Limber uses the move Transform and correctly Transforms with the corresponding Male or Female sprite of the Player's Wobbuffet
• Opponent's Smeargle (Male) uses the move Transform and correctly Transforms with the corresponding Male or Female sprite of the Player's Wobbuffet
• Opponent's Smeargle (Female) uses the move Transform and correctly Transforms with the corresponding Male or Female sprite of the Player's Wobbuffet

I didnt take screenshots or GIFs of every scenario, which maybe I should have, and I don't know of a way to set up tests for this since we can't make tests that check for sprites, but here's a couple screenshots i did remember to grab

[Bassoonian]

Don't worry, that's proof enough! Thanks for taking the time to check this thoroughly!