Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTO_LOWERCASE_KEYBOARD #4976

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

pkmnsnfrn
Copy link
Collaborator

Description

Keyboard changes from upper to lower after first character

  • Adds AUTO_LOWERCASE_KEYBOARD which swaps the keyboard to the lowercase after the first capital letter

Details

Usage

SwapKeyboardToLowerAfterFirstCapitalLetter

This function runs when the following are true:

  • AUTO_LOWERCASE_KEYBOARD is enabled
  • When the keyboard is set to capital
  • The second character is being input

The keyboard will automatically swap to lowercase.

Testing

Clean Branch

You can recreate this branch by applying a patch or pulling the repo. From a clean version of expansion's upcoming, you can either:

Patch

wget https://files.catbox.moe/v0z1pc.patch -O keyboard.patch ; git apply keyboard.patch ; rm keyboard.patch

Repo

git remote add psf-expansion https://github.com/PokemonSanFran/pokeemerald-expansion/ ; git pull psf-expansion swapKeyboard

Manual Tests

After replicating the branch, to recreate my testing environment, you can either directly download the debug script, or manually create the changes.

Download

TRUE

wget https://files.catbox.moe/y2knrw.h -O include/config/general.h

FALSE

wget https://files.catbox.moe/3y97pw.h -O include/config/general.h

Manual Testing

  • Modify include/config/general.h to the desired values
  • Open the Debug Menu, Utilities > Player Name
  • Input a capital letter

Verified Scenarios

All videos show:

  • Open the Debug Menu, Utilities > Player Name
  • Input a capital letter

TRUE

on.mp4

FALSE

off.mp4

People who collaborated with me in this PR

This was originally written by by @Jaizu. Give them all the credit.

Features this PR does NOT handle:

Discord Contact Info

I am pkmnsnfrn on Discord.

src/naming_screen.c Outdated Show resolved Hide resolved
src/naming_screen.c Outdated Show resolved Hide resolved
include/config/general.h Outdated Show resolved Hide resolved
@Bassoonian Bassoonian merged commit 7b3b635 into rh-hideout:upcoming Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants