Deprecate agbcc #4989
Merged
Deprecate agbcc #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Jul 17, 2024
Co-authored-by: Bassoonian <iasperbassoonian@gmail.com>
|
The CI seems to have no issue building agbcc though, weirdly? |
|
Oh I should remove agbcc from the workflow too. |
Oh, very interesting. CI builds it with |
Discussed on Discord—we'll do this at the start of 1.10's life on |
Bassoonian
reviewed
Jul 17, 2024
Bassoonian
approved these changes
Jul 17, 2024
|
🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes
make agbccto exit with an error. Leaves the old implementation commented-out so that it can be reenabled.