Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trainers.h #4990

Merged
merged 1 commit into from
Jul 17, 2024
Merged

trainers.h #4990

merged 1 commit into from
Jul 17, 2024

Conversation

mrgriffin
Copy link
Collaborator

Recent PR changed the #line numbers, so PRing this to prevent trainers.h ending up in other people's PRs by accident.

@mrgriffin
Copy link
Collaborator Author

(I dream of a world where COMPETITIVE_SYNTAX FALSE doesn't exist, and we can stop committing a build artifact. Maybe one day... :))

@AlexOn1ine
Copy link
Collaborator

AlexOn1ine commented Jul 17, 2024

(I dream of a world where COMPETITIVE_SYNTAX FALSE doesn't exist, and we can stop committing a build artifact. Maybe one day... :))

I think it would be worthwhile to do a poll in 5-6 months. If the overwhelming majority uses it then there is no reason to keep the config. Alternatively we can add instructions how to keep using the old system without the config.

@Bassoonian Bassoonian merged commit 23aa9f0 into rh-hideout:upcoming Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants