Fixes spread damage in double battles #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
force-pushed
the
spread_damage
branch
from
3e06d9c to
21d4952
Compare
|
Force pushed because I found a very simple fix and didn't want to remove the changes one by one. |
|
actually I thought of a scenario where this might be still wrong |
all good ready for review again. |
DizzyEggg
approved these changes
Jul 31, 2024
hedara90
added
category: battle-mechanic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In double battles when
B_POSITION_OPPONENT_LEFTfainted from the first hit of a spread move, the second hit dealt 100% of damage toB_POSITION_OPPONENT_RIGHTUsing
gAbsentBattlerFlagsfixes this because it is set when there is no other mon to replace the fainted mon with