Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted AI calcs for Triple Kick Effect #5127

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

Updates AI calcs for the Triple Kick Effect to match it closer to actual damage

@AlexOn1ine AlexOn1ine added the category: battle-ai Pertains to Battle Engine Upgrade's AI label Aug 9, 2024
src/battle_ai_util.c Outdated Show resolved Hide resolved
src/battle_ai_util.c Outdated Show resolved Hide resolved
src/battle_ai_util.c Outdated Show resolved Hide resolved
src/battle_ai_util.c Outdated Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator Author

Shouldn't gMultiHitCounter = 3 be gMultiHitCounter = gMovesInfo[move].strikeCount then?

It doesn't matter in this case but ye that would make more sense.

@Bassoonian
Copy link
Collaborator

Shouldn't gMultiHitCounter = 3 be gMultiHitCounter = gMovesInfo[move].strikeCount then?

It doesn't matter in this case but ye that would make more sense.

If we're going to avoid using the hardcoded 3 in some places we may as well be consistent :)

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Aug 11, 2024

Ready for review.

I noticed that there is a lot of duplicate code in this function which might be worth to clean up but AI calcs already cause a delay so I'm not sure if introducing a new function will make it worse. I'll have to talk with Egg about this. Maybe a macro would be good here actually

@Bassoonian Bassoonian merged commit 527cc33 into rh-hideout:master Aug 11, 2024
1 check passed
@AlexOn1ine AlexOn1ine deleted the tripleKickAiDamage branch November 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-ai Pertains to Battle Engine Upgrade's AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants