Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a sprite issue with B_SHOW_TYPES #5157

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

pkmnsnfrn
Copy link
Collaborator

@pkmnsnfrn pkmnsnfrn commented Aug 13, 2024

Description

Added FreeAllTypeIconResources which fixed an issue with #5131 where the type icon sprite was not being properly handled when hidden.

Testing

Debug_EventScript_Script_1::
+    setflag FLAG_BADGE01_GET
+    setflag FLAG_BADGE02_GET
+    setflag FLAG_BADGE03_GET
+    setflag FLAG_BADGE04_GET
+    setflag FLAG_BADGE05_GET
+    setflag FLAG_BADGE06_GET
+    setflag FLAG_BADGE07_GET
+    setflag FLAG_BADGE08_GET
+    givemon SPECIES_WOBBUFFET,100,ITEM_LEPPA_BERRY
+    givemon SPECIES_GYARADOS,100,ITEM_GYARADOSITE
+    additem ITEM_MEGA_RING,1
+    setwildbattle SPECIES_WOBBUFFET,100,ITEM_LEPPA_BERRY
+    dowildbattle
    release
    end

Video

wobb.mp4

Issue(s) that this PR fixes

Reported on Discord

People who collaborated with me in this PR

Reported by awakeon from RHH Discord

Discord contact info

I am pkmnsnfrn and there is a discussion thread.

Added FreeAllTypeIconResources
Fixed issue where typeIcons were not being properly handled when hidden
@AlexOn1ine AlexOn1ine merged commit 38752b5 into rh-hideout:upcoming Aug 13, 2024
1 check passed
@AlexOn1ine AlexOn1ine added new-feature Adds a feature bugfix Bugfixes labels Aug 14, 2024
@AsparagusEduardo AsparagusEduardo added category: battle-mechanic Pertains to battle mechanics and removed new-feature Adds a feature labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants