Fixed Retaliate not working correctly with passive damage #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e end of turn damage
AlexOn1ine
reviewed
Aug 16, 2024
AlexOn1ine
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pokemon fainted from damage at the end of turn, (e.g. Poison, Burn, Leech Seed, Bind effects), Retaliate did not get the boosted base power the next turn. Instead Retaliate was boosted on the turn after it was supposed to.
Flame Burst was also bugged, fixed it in order to make the tests work.
Description
Moved the decrement of
retaliateTimerto the start of turn instead of end of turn so that it doesn't matter at what point in time during the turn a pokemon faints.Wrote tests for Retaliate interactions I could think of.
Fixed a bug with Flame Burst where current HP was used to calculate damage from Flame Burst AoE effect.
Issue(s) that this PR fixes
#5153
Discord contact info
hedara