Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round Tests #5196

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Round Tests #5196

merged 2 commits into from
Aug 19, 2024

Conversation

hedara90
Copy link
Collaborator

@hedara90 hedara90 commented Aug 18, 2024

Tests for the move Round.

Description

Tests that other battlers that selected Round moves immediately after the first user of Round, both allies and foes.
Tests that the turn order doesn't change otherwise (no exhaustive)
Tests that the other usages of Round has doubled Base Power.
Tests that #5148 hasn't been fixed.

Feature(s) this PR does NOT handle:

#5148 isn't fixed by this PR, it simply implements tests for the move and the bugged behavior.

Discord contact info

hedara

@hedara90 hedara90 added the category: battle-tests Related to the automated test environment label Aug 18, 2024
test/battle/move_effect/round.c Outdated Show resolved Hide resolved
test/battle/move_effect/round.c Outdated Show resolved Hide resolved
test/battle/move_effect/round.c Outdated Show resolved Hide resolved
test/battle/move_effect/round.c Outdated Show resolved Hide resolved
test/battle/move_effect/round.c Show resolved Hide resolved
test/battle/move_effect/round.c Show resolved Hide resolved
@AsparagusEduardo
Copy link
Collaborator

Some readability suggestions, but also recommends checking all 4 move animations just in case

Co-authored-by: Eduardo Quezada <eduardo602002@gmail.com>
@hedara90
Copy link
Collaborator Author

Applied suggestions

@AsparagusEduardo AsparagusEduardo merged commit 3a6c3d5 into rh-hideout:master Aug 19, 2024
1 check passed
@hedara90 hedara90 deleted the round-turn-skip branch August 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants