Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Scale Shot not activating + Known Failing Round test #5292

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fixes Scale Shot not activating + Known Failing Round test #5292

merged 2 commits into from
Aug 30, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

Fixes #5148

Also fixes Scale Shot not activating when gMultiHitCounter was not decreased to zero while opposing mon fainted.

AsparagusEduardo
AsparagusEduardo reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question, everything else lgtm :)

test/battle/move_effect/multi_hit.c Outdated Show resolved Hide resolved
@AsparagusEduardo AsparagusEduardo merged commit addaf40 into rh-hideout:master Aug 30, 2024
1 check passed
@AlexOn1ine AlexOn1ine added category: move effect Pertains to move effects bugfix Bugfixes labels Sep 1, 2024
@AlexOn1ine AlexOn1ine deleted the roundPlusMultiHits branch November 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
bugfix Bugfixes category: move effect Pertains to move effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Round preventing Pokemon to make a Move
2 participants
@AlexOn1ine @AsparagusEduardo