Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen 9 Follower pokemon sprites #5304

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Conversation

Liamjd14
Copy link

@Liamjd14 Liamjd14 commented Aug 31, 2024

Adds most of the gen 9 pokemon ow / follower sprites.

Description

Adds images and data for all gen 9 pokemon to have follower sprites except for terapagos stellar form and roaming ghimmigoul.
I plan on adding asym sprites for scovillain, and the tinkaton line in the future (the sprites are allrady there, just the code needs adding to get them to work).

Images

Screenshots of some of the follower sprites working:

pokeemerald-0 pokeemerald-1 pokeemerald-2 pokeemerald-3 pokeemerald-4 pokeemerald-5 pokeemerald-6 pokeemerald-7 pokeemerald-8

People who collaborated with me in this PR

Formatted by: Liamjd14
Original sprites by:
Darkus_Shadow, Princess-Phoenix, shaderr31, Molfang62, CarmaNekko, EduarPokeN, Larryturbo, TyranitarDark, Anarlaurendil
Sounces:
Normal: https://www.deviantart.com/darkusshadow/art/Gen-9-Paldea-Pokemon-Overworld-Sprites-967776690
Shiny: https://www.deviantart.com/darkusshadow/art/SHINY-Gen-9-Paldea-Pokemon-Overworld-Sprites-967779547

Discord contact info

Liamjd14

All gen 9 followers currently done. Missing Bloodmoon Ursaluna, Stellar form Terapagos, Ghimmigool Roaming Form and two way sprites for some mons.
@hedara90 hedara90 self-assigned this Sep 1, 2024
@hedara90 hedara90 added category: pokemon Pertains to Pokémon data and functionality category: overworld Pertains to out-of-battle mechanics labels Sep 1, 2024
graphics/pokemon/quaxwell/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/quaquaval/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/oinkologne/female/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/lokix/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/tandemaus/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/gouging_fire/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/raging_bolt/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/iron_boulder/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/terapagos/terastal/overworld.png Outdated Show resolved Hide resolved
src/data/pokemon/species_info/gen_5_families.h Outdated Show resolved Hide resolved
@Liamjd14
Copy link
Author

Liamjd14 commented Sep 4, 2024

Hi there, I have most of the changes done on my end. A couple of them i have been unable to add due to colour pallet restrictions.
The terapagos sprite now has the right colors but currently the shiny dosen't have the right head color due to there not beign any free space on the pallet.

Also whats with the last 'fix EOL' as i have checked the files on my end and the shown change on here is allready there?

@hedara90
Copy link
Collaborator

hedara90 commented Sep 4, 2024

Also whats with the last 'fix EOL' as i have checked the files on my end and the shown change on here is allready there?

20240904_21h22m14s_grim
It's a thing where the last line in the file doesn't have a \n.
It's a thing that some text editors do, text editors should warn you if the file you're editing doesn't have one.

I have most of the changes done on my end. A couple of them i have been unable to add due to colour pallet restrictions.
The terapagos sprite now has the right colors but currently the shiny doesn't have the right head color due to there not beign any free space on the pallet.

Mark the ones that are fixed as resolved.
We can deal with ones that require more involved fixes later.

@Liamjd14
Copy link
Author

Liamjd14 commented Sep 4, 2024

I have marked off all the ones im sure are fixed. just left the ones that might need more work.
Klawf - not sure what is needed to make it look better
Iron juggulis - not sure on how to improve the north sprite
Gouging fire - not sure if the colors i have used are right or not
Terapagos - still needs some work as shiny is currently inaccurate due to pallet limitations

also i coppied the change on the 'fix EOL' to the file. hopefully it saved but might be worth checking as im not sure

@hedara90
Copy link
Collaborator

hedara90 commented Sep 4, 2024

The EOL was fixed, I marked it as resolved when I saw it change.
Gouging Fire looks good now.
Iron Juggulis I don't actually know what can be done with.

@Liamjd14
Copy link
Author

Liamjd14 commented Sep 4, 2024

Thats good then, if you think gouging fire is good then i will mark it off. Didnt know what to do with iron juggulis myself due to its color scheme.

@Liamjd14
Copy link
Author

Liamjd14 commented Sep 4, 2024

What do you think to these two. Updated Klawf Shiny, and Terapagos rework (slightly change colors and shiny.)

Terapagos OW:
moverworld
mmoverworld

Klawf OW:
overworld

@hedara90
Copy link
Collaborator

hedara90 commented Sep 5, 2024

Those look good

Adds Terapagos changes and shiny klawf changes
@Liamjd14
Copy link
Author

Liamjd14 commented Sep 5, 2024

Hi there, I have pushed the changes to it and resolved the relevant changes.

Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another bunch of things noticed.

graphics/pokemon/clodsire/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/dachsbun/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/dondozo/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/frigibax/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/gouging_fire/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/tandemaus/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/tinkaton/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/wo_chien/overworld.png Outdated Show resolved Hide resolved
graphics/pokemon/wooper/wooper_paldean/overworld.png Outdated Show resolved Hide resolved
src/data/pokemon/species_info/gen_2_families.h Outdated Show resolved Hide resolved
@Liamjd14
Copy link
Author

Liamjd14 commented Sep 5, 2024

all changes show on my end.

Fixes:
Blinking Ear on dachbun
Dondozo - change pallet to keep white eye on shiny
Frigibax - change pallet to show pink hands on shiny
gouging fire - change pallet to allow for red on normal and aditional fix to shiny
great tusk - simplified grey to allow for right color on tusks
klawf - change pallet to show correct cheeks
koraidon - fixed blinking
lokix - fixed shiny blinking
ogerpon - change color to reflect shiny battle sprite
oinkalone - fixes blinking
quaquavel - fixed blinking colors
tandamous - removed stray pixel
tinkaton - fixed blinking pixel
wochen - fixed blinking pixel
houndstone - fixed brown pixel on left-right sprite

how is best to handle the wooper and clodsire sprites as i did not realize there were already ones? should i just delete the files on mine or replace them with the ones from the expansion repo.

@hedara90
Copy link
Collaborator

hedara90 commented Sep 5, 2024

You should be able to add back the ones that were already there, worst you can copy the sprite and palettes back in from master.

@Liamjd14
Copy link
Author

Liamjd14 commented Sep 5, 2024

That should be all of the changes done then.

@hedara90 hedara90 merged commit e9c0784 into rh-hideout:master Sep 5, 2024
1 check passed
@hedara90
Copy link
Collaborator

hedara90 commented Sep 5, 2024

Awesome work getting all these done!

@Liamjd14
Copy link
Author

Liamjd14 commented Sep 5, 2024

Just glad i can contribute to the expansion. Will have a look in the sprite issues when i get a second and see if there are i can help with.

@Liamjd14 Liamjd14 deleted the Gen9Followers branch September 13, 2024 17:21
KittyPBoxx pushed a commit to KittyPBoxx/pokeemerald-ex-speedchoice-maprando-gen9 that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: overworld Pertains to out-of-battle mechanics category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants