Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass/Water Pledge Swamp Animation + Sea of Fire animation tweak #5325

Merged
merged 8 commits into from
Sep 7, 2024

Conversation

SonikkuA-DatH
Copy link

@SonikkuA-DatH SonikkuA-DatH commented Sep 5, 2024

Resolves #3588
Gives the Water + Grass combo a unique swamp animation for the lingering effect

swampC.mp4

Also tweaks Sea of Fire to fade bg and mon palettes for its set effect

Fire3.mp4

Discord;
dat.ha, originally Dat.HA#6907

@SonikkuA-DatH SonikkuA-DatH changed the title Upcoming Grass/Water Pledge Swamp Animation + Sea of Fire animation tweak Sep 5, 2024
@hedara90 hedara90 self-assigned this Sep 5, 2024
@hedara90 hedara90 added the category: move animation Pertains to move animations label Sep 5, 2024
@hedara90
Copy link
Collaborator

hedara90 commented Sep 5, 2024

Could the Swamp end of turn effect go BG fade in -> Rain effect -> green shake -> BG Fade out?
Right now I think it looks a bit strange with the half fade(?) then rain then the BG.

@SonikkuA-DatH
Copy link
Author

Could the Swamp end of turn effect go BG fade in -> Rain effect -> green shake -> BG Fade out? Right now I think it looks a bit strange with the half fade(?) then rain then the BG.

Like this?

swampC.mp4

@hedara90
Copy link
Collaborator

hedara90 commented Sep 6, 2024

Like this?
swampC.mp4

Yea, I think that looks better.

Copy link
Collaborator

@hedara90 hedara90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good (literally)

@hedara90 hedara90 merged commit 8c3531f into rh-hideout:upcoming Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: move animation Pertains to move animations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants