Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert rtc based encounters #5331

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

As pointed out by Jasper this implementation has flaws.

@Bassoonian Bassoonian merged commit 5c86aa1 into rh-hideout:upcoming Sep 6, 2024
1 check passed
@hjk321
Copy link

hjk321 commented Sep 8, 2024

It wasn't "flawed", and there's nothing wrong with the implementation. It just has a minor inconvenience associated with it.

While I agree that Jasper's implementation would be better than mine if the porymap tabs issue can be worked out, iirc they said in that same conversation that they do not intend to PR it soon because of said issues. As it stands now I feel like the inconvenience to the end user is about the same for both implementations.

I respecfully request that my implementation be revisited closer to release if the other one has not been PR'd or merged by that time. IMO at least it is better to have a feature than no feature.

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Sep 8, 2024

It wasn't "flawed", and there's nothing wrong with the implementation. It just has a minor inconvenience associated with it.

Sorry, this wasn't the correct word to use, I agree.

@AsparagusEduardo AsparagusEduardo added the category: overworld Pertains to out-of-battle mechanics label Sep 9, 2024
@AlexOn1ine AlexOn1ine deleted the revertRTCBasedEncounters branch November 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: overworld Pertains to out-of-battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants