Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follower pokemon fixes from #5135 (gen 2 to 4) #5332

Closed
wants to merge 9 commits into from

Conversation

Liamjd14
Copy link

@Liamjd14 Liamjd14 commented Sep 6, 2024

Fixes some of the issues with follower pokemon in issue #5135

Description

Fixes the following issues from #5135
Currently:
Meganium south follower blinking neck flower
Ledyba south follower blinking by hands
Ledian south follower blinking by eyes
Spinarak east/west follower blinking
Crobat south follower eyes blinking
Igglybuff east/west follower butt blinking
Xatu north head feathers base blinking
Flaaffy south head blinking
Hoppip east/west follower forehead blinking
Skiploom follower not-north blinking
Jumpluff follower east/west under top cotton ball blinking
Yanma follower not-north blinking
Wooper south cheeks blinking
Mantine follower not-south blinking
Skarmory follower east-west head blinking
Donphan follower south ears blinking
Miltank follower south under nose blinking
Raikou follower south blinking
Grovyle follower north head leaf blinking
Marshtomp follower south and north head fin blinking
Mightyena follower south blinking by right ear
Illumise South blinking by left antennae
Numel north blinking on ears
Torkoal south blinking nose, north no movement
Flygon blinking east/west back of head, (and maybe eye on south)
Crawdaunt north blinking on back
Armalde blinking south head
Prinplup south blinking top arms
Staraptor east/west blinking face
Roserade south left arm blinking
Shieldon follower normal palette has green elements where itshouldn't
Ambipom north blinking hair
Stunky south blinking tail base
Mamoswine south blinking sides

Issue(s) that this PR fixes

Fixes some of the issues in: Current sprite issues #5135

Feature(s) this PR does NOT handle:

Anything in #5135 not listed above.

Discord contact info

Liamjd14

flaaffy
xatu
hoppip line
Mantine
Miltank
Raikou
yanma
wooper
skarmory
Armaldo
Crawdaunt
Flygon
Illumise
Numel
Torkol
prinplup
starraptor
shieldon
roserade
ambipom
mamoswine
Stunky

Donphan - gen 2 fix
Espion - noticed a flickering pixel on south walk
@Cafeei Cafeei mentioned this pull request Sep 6, 2024
@Liamjd14 Liamjd14 marked this pull request as ready for review September 7, 2024 05:04
@hedara90 hedara90 added category: pokemon Pertains to Pokémon data and functionality category: overworld Pertains to out-of-battle mechanics labels Sep 7, 2024
@hedara90 hedara90 self-assigned this Sep 7, 2024
@hedara90
Copy link
Collaborator

hedara90 commented Sep 7, 2024

PR'd to your branch to fix up synchronization with Cafeei's fixes.

This was referenced Sep 7, 2024
@hedara90
Copy link
Collaborator

hedara90 commented Sep 9, 2024

Resolved the merge with #5334

@hedara90 hedara90 closed this Sep 9, 2024
@Liamjd14 Liamjd14 deleted the FollowerPokemonFixes branch September 9, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: overworld Pertains to out-of-battle mechanics category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants